PROD - Fix for PM-3108 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| p.created_at, | ||
| w.winner_id as user_id | ||
| FROM finance.payment p | ||
| INNER JOIN finance.winnings w on p.winnings_id = w.winning_id |
There was a problem hiding this comment.
[performance]
The join condition uses p.winnings_id = w.winning_id. Ensure that both winnings_id and winning_id are indexed to optimize the join performance, especially if these tables are large.
| WHERE p.created_at >= $1::timestamptz | ||
| AND p.created_at <= $2::timestamptz | ||
| ORDER BY p.created_at DESC; | ||
| AND p.billing_account = '80000062' |
There was a problem hiding this comment.
[maintainability]
The hardcoded billing account value '80000062' could lead to maintainability issues if this value needs to change in the future. Consider parameterizing this value to improve flexibility and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.